From 96f2b34abc18a3f6d2b22b462cadbf764058cc26 Mon Sep 17 00:00:00 2001
From: michael <operations@dangerousthings.com>
Date: Tue, 26 May 2026 14:00:21 -0700
Subject: [PATCH] docs/build: clean up stale aliro-applet.cap references after
 profile split

Code review of 750f570 flagged three Important issues:
- Stale 'Output: target/aliro-applet.cap' comment in pom.xml antrun
  plugin block.
- applet/INSTALL.md referenced the old single-CAP filename in three
  places, breaking the documented gp.jar --load command.
- No safeguard or hint that -Pj3r180 and -Pj3r452 are mutually exclusive.

Updates the comments and the INSTALL.md filenames to point at
aliro-applet-j3r180.cap as the default. Adds mutual-exclusion notes
to both profile blocks.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 applet/INSTALL.md | 12 +++++++-----
 applet/pom.xml    |  5 ++++-
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/applet/INSTALL.md b/applet/INSTALL.md
index 3d016c1..decf698 100644
--- a/applet/INSTALL.md
+++ b/applet/INSTALL.md
@@ -24,9 +24,11 @@ cd applet
 ./scripts/dt-mvn.sh clean package -DskipTests
 ```
 
-Output: `applet/target/aliro-applet.cap` (~42 KB). Built inside the
-`vivokey/smartcard-ci` container by the `ant-javacard` plugin against the
-JC 3.0.5 SDK.
+Output: `applet/target/aliro-applet-j3r180.cap` (~42 KB). Built inside
+the `vivokey/smartcard-ci` container by the `ant-javacard` plugin
+against the JC 3.0.5 SDK. Add `-Pj3r452` to build the AMD-H variant
+(`aliro-applet-j3r452.cap`) instead; the j3r180 default is what's
+shipped in the field today, so use it if you're not sure.
 
 ## Install
 
@@ -37,7 +39,7 @@ java -jar gp.jar --info                          # confirm reader sees the card
 # --create needs the instance AID, the applet class AID (same as instance
 # here), and the package AID (printed by --load).
 PKG=A0000009094454414C49524F
-java -jar gp.jar --load applet/target/aliro-applet.cap
+java -jar gp.jar --load applet/target/aliro-applet-j3r180.cap
 java -jar gp.jar --create A000000909ACCE5501   --applet A000000909ACCE5501   --package $PKG
 java -jar gp.jar --create A000000909ACCE5502   --applet A000000909ACCE5502   --package $PKG
 java -jar gp.jar --create A000000909ACCE559901 --applet A000000909ACCE559901 --package $PKG
@@ -193,7 +195,7 @@ deletes them) but only if the CAP file is reachable from the current
 directory, since `gp` resolves it as a path:
 
 ```
-java -jar gp.jar --uninstall ./aliro-applet.cap
+java -jar gp.jar --uninstall ./aliro-applet-j3r180.cap
 ```
 
 ## Troubleshooting
diff --git a/applet/pom.xml b/applet/pom.xml
index b0eedeb..f65e372 100644
--- a/applet/pom.xml
+++ b/applet/pom.xml
@@ -88,7 +88,7 @@
                 Oracle's converter from the JC SDK pinned by JC_CLASSIC_HOME
                 (the dt-mvn.sh wrapper sets this to /app/sdks/jc305u3_kit).
 
-                Output: target/aliro-applet.cap
+                Output: target/aliro-applet-${cap.variant}.cap (j3r180 default; -Pj3r452 for AMD-H variant)
 
                 Package AID:     A0 00 00 09 09 44 54 41 4C 49 52 4F  (CSA RID + "DTALIRO")
                 Applet AIDs:
@@ -145,15 +145,18 @@
 
     <profiles>
         <profile>
+            <!-- Mutually exclusive with j3r452. Activate exactly one. -->
             <id>j3r180</id>
             <activation><activeByDefault>true</activeByDefault></activation>
             <properties>
+                <!-- cap.variant: consumed by later tasks (CI matrix, profile-conditional source roots). -->
                 <cap.variant>j3r180</cap.variant>
                 <cap.elf.aid>A0000009094454414C49524F</cap.elf.aid>
                 <cap.output.name>aliro-applet-j3r180.cap</cap.output.name>
             </properties>
         </profile>
         <profile>
+            <!-- Mutually exclusive with j3r180. Activate exactly one. -->
             <id>j3r452</id>
             <properties>
                 <cap.variant>j3r452</cap.variant>