MikeFaith/dt-nfc-identifier
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix NTAG 413/424 DNA detection using correct GET_VERSION parsing

Browse Source 
Per NXP datasheets (NT4H1321, NT4H2421), NTAG DNA chips return product
type 0x04 with major version 0x04, distinguished by subtype:
- NTAG 413 DNA: subtype 0x02
- NTAG 424 DNA: subtype 0x05
- NTAG 424 DNA TT: subtype 0x04

Previously incorrectly expected product type 0x21 or hwMajor >= 0x30,
causing Spark 2 implants to be detected as "DESFire Unknown" when the
vivokey.co NDEF record was not present.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
michael
2026-01-27 17:10:50 -08:00
parent 77bce6a815
commit cce7629eb6
1 changed files with 40 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
src/services/detection/desfire.ts
View File

@@ -78,13 +78,27 @@ export function detectSpark2FromNdef(
/** /**
* Product type values from GET_VERSION byte 1 * Product type values from GET_VERSION byte 1
* Per NXP datasheets:
* - NTAG 413 DNA (NT4H1321): Type 0x04, Subtype 0x02
* - NTAG 424 DNA (NT4H2421): Type 0x04, Subtype 0x05
* - NTAG 424 DNA TT: Type 0x04, Subtype 0x04
* - DESFire EV1/EV2/EV3: Type 0x01
*/ */
const PRODUCT_TYPES = { const PRODUCT_TYPES = {
DESFIRE: 0x01, // Standard DESFire DESFIRE: 0x01, // Standard DESFire
NTAG: 0x04, // NTAG family (including NTAG 413 DNA which uses 0x04) NTAG_DNA: 0x04, // NTAG DNA family (413/424) - distinguished by subtype
NTAG_I2C: 0x05, // NTAG I2C family (can have ISO-DEP on Plus variants) NTAG_I2C: 0x05, // NTAG I2C family (can have ISO-DEP on Plus variants)
DESFIRE_LIGHT: 0x08, // DESFire Light DESFIRE_LIGHT: 0x08, // DESFire Light
NTAG_424_DNA: 0x21, // NTAG 424 DNA family } as const;
/**
* NTAG DNA subtype values from GET_VERSION byte 2
* Per NXP NT4H1321 and NT4H2421 datasheets
*/
const NTAG_DNA_SUBTYPES = {
NTAG413_DNA: 0x02, // NTAG 413 DNA
NTAG424_DNA_TT: 0x04, // NTAG 424 DNA TagTamper
NTAG424_DNA: 0x05, // NTAG 424 DNA
} as const; } as const;
/** /**
@@ -246,29 +260,31 @@ export async function detectDesfire(): Promise<DesfireDetectionResult> {
// Determine chip type based on product type and version // Determine chip type based on product type and version
let chipType: ChipType; let chipType: ChipType;
if (hwProductType === PRODUCT_TYPES.NTAG_424_DNA) { if (hwProductType === PRODUCT_TYPES.NTAG_DNA) {
// NTAG 424 DNA family uses product type 0x21 // NTAG DNA family (413/424) - distinguish by subtype per NXP datasheets
// Subtype 0x02 = TagTamper variant (424 DNA TT only) // NT4H1321 (NTAG 413 DNA): Subtype 0x02, Major 0x04
// Storage size helps differentiate: // NT4H2421 (NTAG 424 DNA): Subtype 0x05, Major 0x04
// - NTAG 413 DNA: ~160 bytes user memory (storage code <= 0x0E) // NT4H2421 TT (NTAG 424 DNA TagTamper): Subtype 0x04, Major 0x04
// - NTAG 424 DNA: ~416 bytes user memory (storage code >= 0x0F) switch (hwSubtype) {
if (hwSubtype === 0x02) { case NTAG_DNA_SUBTYPES.NTAG413_DNA:
chipType = ChipType.NTAG424_DNA_TT; console.log('[DESFire] Detected NTAG 413 DNA (product 0x04, subtype 0x02)');
} else if (hwStorageSize <= 0x0e) { chipType = ChipType.NTAG413_DNA;
// Smaller storage indicates NTAG 413 DNA (~160 bytes) break;
chipType = ChipType.NTAG413_DNA; case NTAG_DNA_SUBTYPES.NTAG424_DNA_TT:
} else { console.log('[DESFire] Detected NTAG 424 DNA TT (product 0x04, subtype 0x04)');
// Larger storage indicates NTAG 424 DNA (~416 bytes) chipType = ChipType.NTAG424_DNA_TT;
chipType = ChipType.NTAG424_DNA; break;
case NTAG_DNA_SUBTYPES.NTAG424_DNA:
console.log('[DESFire] Detected NTAG 424 DNA (product 0x04, subtype 0x05)');
chipType = ChipType.NTAG424_DNA;
break;
default:
// Unknown NTAG DNA subtype - log and fall back to 424 DNA as most common
console.warn(
`[DESFire] Unknown NTAG DNA subtype: 0x${hwSubtype.toString(16)}, major: 0x${hwMajor.toString(16)}`,
);
chipType = ChipType.NTAG424_DNA;
} }
} else if (hwProductType === PRODUCT_TYPES.NTAG && hwMajor >= 0x30) {
// NTAG 413 DNA returns product type 0x04 (like regular NTAG) but with:
// - hwMajor >= 0x30 (typically 0x30)
// - hwStorageSize 0x11 (different meaning than regular NTAG)
// - Responds to IsoDep (unlike regular NTAG 21x)
// Per NXP NT4H1321 datasheet, NTAG 413 DNA uses this response format
console.log('[DESFire] Detected NTAG 413 DNA (product type 0x04, hwMajor 0x30+)');
chipType = ChipType.NTAG413_DNA;
} else if (hwProductType === PRODUCT_TYPES.NTAG_I2C) { } else if (hwProductType === PRODUCT_TYPES.NTAG_I2C) {
// NTAG I2C family (can have ISO-DEP on Plus variants) // NTAG I2C family (can have ISO-DEP on Plus variants)
// Per NXP NT3H2111/NT3H2211 datasheet: // Per NXP NT3H2111/NT3H2211 datasheet: