MikeFaith/pm3py
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(pm3py): on=False now correctly turns LEDs off instead of on

Browse Source
This commit is contained in:
michael
2026-03-16 00:25:36 -07:00
parent a91d862647
commit 18817f75d3
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pm3py/hw.py
View File

@@ -86,8 +86,11 @@ class HWCommands:
else: else:
led_mask = self._parse_led_str(led) led_mask = self._parse_led_str(led)
# Resolve action # Resolve action — explicit False means "off"
if brightness >= 0: if on is False and not any([off, toggle, pulse, fade, blink, brightness >= 0]):
action_code = 0
brightness_val = 0
elif brightness >= 0:
action_code = 3 action_code = 3
brightness_val = min(max(brightness, 0), 100) brightness_val = min(max(brightness, 0), 100)
elif off: elif off:
@@ -105,7 +108,7 @@ class HWCommands:
elif blink: elif blink:
action_code = 6 action_code = 6
brightness_val = 0 brightness_val = 0
elif on or True: # default to "on" else: # default to "on"
action_code = 1 action_code = 1
brightness_val = 0 brightness_val = 0